Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)

talpid-wireguard/src/connectivity/mod.rs line 9 at r1 (raw file):

mod pinger;

pub use check::Cancellable;

⛏️ Technically this should be gated on android or force_wireguard_handshake? 🫠

Code quote:

pub use check::Cancellable;

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dlon)

talpid-wireguard/src/ephemeral.rs line 122 at r2 (raw file):

) -> Result<(), CloseMsg> {
    #[cfg(force_wireguard_handshake)]
    let _ = establish_tunnel_connection(tunnel, connectivity).await;

Would be nice with an explicit comment about why the return value is discarded. Obviously we care about the side effect of calling establish_tunnel_connection only.

Code quote:

    #[cfg(force_wireguard_handshake)]
    let _ = establish_tunnel_connection(tunnel, connectivity).await;

Reviewable status: 3 of 6 files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)

talpid-wireguard/src/ephemeral.rs line 122 at r2 (raw file):

Done.

talpid-wireguard/src/connectivity/mod.rs line 9 at r1 (raw file):

(Merged them as suggested.)

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved